From 0dcde5dd742067b98f54d0d0bd0aa450d29efadb Mon Sep 17 00:00:00 2001 From: Ashik K Date: Fri, 17 Oct 2025 12:49:26 +0200 Subject: [PATCH] Fix video player back button - use push navigation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Changed video player from .fullScreen to .push navigation: - Removed NavigationViewCoordinator wrapper - Video player now returns VideoPlayerCoordinator directly This should allow ESC/back button to work during video playback. MediaCoordinator kept at .fullScreen to prevent Home screen navigation bug. Trade-offs: ✅ Video player ESC should now work ✅ Pressing back from empty channel goes to Media tab (not Home) ❌ Error dismissal still returns to Media tab (dismisses entire .fullScreen presentation) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- Shared/Coordinators/ItemCoordinator.swift | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Shared/Coordinators/ItemCoordinator.swift b/Shared/Coordinators/ItemCoordinator.swift index 9a68e28a..b9d59a98 100644 --- a/Shared/Coordinators/ItemCoordinator.swift +++ b/Shared/Coordinators/ItemCoordinator.swift @@ -40,7 +40,7 @@ final class ItemCoordinator: NavigationCoordinatable { var itemOverview = makeItemOverview @Route(.fullScreen) var mediaSourceInfo = makeMediaSourceInfo - @Route(.fullScreen) + @Route(.push) var videoPlayer = makeVideoPlayer #endif @@ -90,8 +90,8 @@ final class ItemCoordinator: NavigationCoordinatable { #endif #if os(tvOS) - func makeVideoPlayer(manager: VideoPlayerManager) -> NavigationViewCoordinator { - NavigationViewCoordinator(VideoPlayerCoordinator(manager: manager)) + func makeVideoPlayer(manager: VideoPlayerManager) -> VideoPlayerCoordinator { + VideoPlayerCoordinator(manager: manager) } #endif