From 9530673c4661a1534f7ee5908c4656f3f47d0ecf Mon Sep 17 00:00:00 2001 From: David Ullmer Date: Mon, 11 Jul 2022 17:59:40 +0200 Subject: [PATCH] Implement suggestions --- Shared/Generated/Strings.swift | 4 ++-- Swiftfin/Views/PublicUserSignInCellView.swift | 3 ++- Swiftfin/Views/UserSignInView.swift | 1 + Translations/en.lproj/Localizable.strings | Bin 13016 -> 13016 bytes 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/Shared/Generated/Strings.swift b/Shared/Generated/Strings.swift index 9c86798e..8b668a97 100644 --- a/Shared/Generated/Strings.swift +++ b/Shared/Generated/Strings.swift @@ -198,7 +198,7 @@ internal enum L10n { internal static var `none`: String { return L10n.tr("Localizable", "none") } /// No overview available internal static var noOverviewAvailable: String { return L10n.tr("Localizable", "noOverviewAvailable") } - /// No public users + /// No public Users internal static var noPublicUsers: String { return L10n.tr("Localizable", "noPublicUsers") } /// No results. internal static var noResults: String { return L10n.tr("Localizable", "noResults") } @@ -260,7 +260,7 @@ internal enum L10n { internal static var previousItem: String { return L10n.tr("Localizable", "previousItem") } /// Programs internal static var programs: String { return L10n.tr("Localizable", "programs") } - /// Public users + /// Public Users internal static var publicUsers: String { return L10n.tr("Localizable", "publicUsers") } /// Rated internal static var rated: String { return L10n.tr("Localizable", "rated") } diff --git a/Swiftfin/Views/PublicUserSignInCellView.swift b/Swiftfin/Views/PublicUserSignInCellView.swift index 5771ed24..84b10ab9 100644 --- a/Swiftfin/Views/PublicUserSignInCellView.swift +++ b/Swiftfin/Views/PublicUserSignInCellView.swift @@ -31,12 +31,13 @@ struct UserLoginCellView: View { HStack { ImageView(viewModel.getProfileImageUrl(user: user)) { Image(systemName: "person.circle") + .resizable() .frame(width: 50, height: 50) } .frame(width: 50, height: 50) .clipShape(Circle()) - Text(user.name ?? "") + Text(user.name ?? "--") Spacer() } } diff --git a/Swiftfin/Views/UserSignInView.swift b/Swiftfin/Views/UserSignInView.swift index a4c0d0fc..b2940d41 100644 --- a/Swiftfin/Views/UserSignInView.swift +++ b/Swiftfin/Views/UserSignInView.swift @@ -74,6 +74,7 @@ struct UserSignInView: View { .disabled(viewModel.isLoadingUsers || viewModel.isLoading) } } + .headerProminence(.increased) } .alert(item: $viewModel.errorMessage) { _ in Alert(title: Text(viewModel.alertTitle), diff --git a/Translations/en.lproj/Localizable.strings b/Translations/en.lproj/Localizable.strings index f41baf6ac0d596451f41bd47c8b58a49b368d14e..4471fd68383feec5d1b3205c800271ff23a0cf0e 100644 GIT binary patch delta 34 ocmcbSdLwm1oe^W`%xc~qF delta 32 mcmcbSdLwm1ozdh4nqrfu7?}u^G88kUG86$xB?fB-E(QS5;|YTR