Merge pull request #310 from dcordero/accessibility

Accessibility fixes
This commit is contained in:
Ethan Pippin 2022-01-17 13:34:10 -07:00 committed by GitHub
commit 9e9baed0ff
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 11 additions and 2 deletions

View File

@ -78,6 +78,8 @@ internal enum L10n {
internal static var `continue`: String { return L10n.tr("Localizable", "continue") } internal static var `continue`: String { return L10n.tr("Localizable", "continue") }
/// Continue Watching /// Continue Watching
internal static var continueWatching: String { return L10n.tr("Localizable", "continueWatching") } internal static var continueWatching: String { return L10n.tr("Localizable", "continueWatching") }
/// Current Position
internal static var currentPosition: String { return L10n.tr("Localizable", "currentPosition") }
/// Customize /// Customize
internal static var customize: String { return L10n.tr("Localizable", "customize") } internal static var customize: String { return L10n.tr("Localizable", "customize") }
/// Dark /// Dark
@ -254,6 +256,8 @@ internal enum L10n {
internal static var regular: String { return L10n.tr("Localizable", "regular") } internal static var regular: String { return L10n.tr("Localizable", "regular") }
/// Released /// Released
internal static var released: String { return L10n.tr("Localizable", "released") } internal static var released: String { return L10n.tr("Localizable", "released") }
/// Remaining Time
internal static var remainingTime: String { return L10n.tr("Localizable", "remainingTime") }
/// Remove /// Remove
internal static var remove: String { return L10n.tr("Localizable", "remove") } internal static var remove: String { return L10n.tr("Localizable", "remove") }
/// Remove All Users /// Remove All Users

View File

@ -26,7 +26,6 @@ struct ServerListView: View {
ZStack(alignment: Alignment.leading) { ZStack(alignment: Alignment.leading) {
Rectangle() Rectangle()
.foregroundColor(Color(UIColor.secondarySystemFill)) .foregroundColor(Color(UIColor.secondarySystemFill))
.frame(height: 100)
.cornerRadius(10) .cornerRadius(10)
HStack(spacing: 10) { HStack(spacing: 10) {
@ -48,7 +47,7 @@ struct ServerListView: View {
.font(.footnote) .font(.footnote)
.foregroundColor(.primary) .foregroundColor(.primary)
} }
}.padding([.leading]) }.padding()
} }
.padding() .padding()
} }

View File

@ -340,6 +340,8 @@ struct VLCPlayerOverlayView: View {
Text(viewModel.leftLabelText) Text(viewModel.leftLabelText)
.font(.system(size: 18, weight: .semibold, design: .default)) .font(.system(size: 18, weight: .semibold, design: .default))
.frame(minWidth: 70, maxWidth: 70) .frame(minWidth: 70, maxWidth: 70)
.accessibilityLabel(L10n.currentPosition)
.accessibilityValue(viewModel.leftLabelText)
ValueSlider(value: $viewModel.sliderPercentage, onEditingChanged: { editing in ValueSlider(value: $viewModel.sliderPercentage, onEditingChanged: { editing in
viewModel.sliderIsScrubbing = editing viewModel.sliderIsScrubbing = editing
@ -358,6 +360,8 @@ struct VLCPlayerOverlayView: View {
Text(viewModel.rightLabelText) Text(viewModel.rightLabelText)
.font(.system(size: 18, weight: .semibold, design: .default)) .font(.system(size: 18, weight: .semibold, design: .default))
.frame(minWidth: 70, maxWidth: 70) .frame(minWidth: 70, maxWidth: 70)
.accessibilityLabel(L10n.remainingTime)
.accessibilityValue(viewModel.rightLabelText)
} }
.padding(.horizontal) .padding(.horizontal)
.frame(maxWidth: UIDevice.current.userInterfaceIdiom == .pad ? 800 : nil) .frame(maxWidth: UIDevice.current.userInterfaceIdiom == .pad ? 800 : nil)

View File

@ -489,6 +489,8 @@ extension VLCPlayerViewController {
} }
private func hideOverlay() { private func hideOverlay() {
guard !UIAccessibility.isVoiceOverRunning else { return }
guard let overlayHostingController = currentOverlayHostingController else { return } guard let overlayHostingController = currentOverlayHostingController else { return }
guard overlayHostingController.view.alpha != 0 else { return } guard overlayHostingController.view.alpha != 0 else { return }