From c4a3670cece4d6a5adb6d2ed4207e21f6250be4e Mon Sep 17 00:00:00 2001 From: David Cordero Date: Mon, 17 Jan 2022 20:37:55 +0100 Subject: [PATCH] Add accessibilityLabels to the currentPosition and reminingTime labels in the player overlay --- Shared/Generated/Strings.swift | 4 ++++ .../Views/VideoPlayer/Overlays/VLCPlayerOverlayView.swift | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/Shared/Generated/Strings.swift b/Shared/Generated/Strings.swift index 3d7d1eb7..8b6fe26b 100644 --- a/Shared/Generated/Strings.swift +++ b/Shared/Generated/Strings.swift @@ -78,6 +78,8 @@ internal enum L10n { internal static var `continue`: String { return L10n.tr("Localizable", "continue") } /// Continue Watching internal static var continueWatching: String { return L10n.tr("Localizable", "continueWatching") } + /// Current Position + internal static var currentPosition: String { return L10n.tr("Localizable", "currentPosition") } /// Customize internal static var customize: String { return L10n.tr("Localizable", "customize") } /// Dark @@ -254,6 +256,8 @@ internal enum L10n { internal static var regular: String { return L10n.tr("Localizable", "regular") } /// Released internal static var released: String { return L10n.tr("Localizable", "released") } + /// Remaining Time + internal static var remainingTime: String { return L10n.tr("Localizable", "remainingTime") } /// Remove internal static var remove: String { return L10n.tr("Localizable", "remove") } /// Remove All Users diff --git a/Swiftfin/Views/VideoPlayer/Overlays/VLCPlayerOverlayView.swift b/Swiftfin/Views/VideoPlayer/Overlays/VLCPlayerOverlayView.swift index 2925ea77..ce9979f0 100644 --- a/Swiftfin/Views/VideoPlayer/Overlays/VLCPlayerOverlayView.swift +++ b/Swiftfin/Views/VideoPlayer/Overlays/VLCPlayerOverlayView.swift @@ -340,6 +340,8 @@ struct VLCPlayerOverlayView: View { Text(viewModel.leftLabelText) .font(.system(size: 18, weight: .semibold, design: .default)) .frame(minWidth: 70, maxWidth: 70) + .accessibilityLabel(L10n.currentPosition) + .accessibilityValue(viewModel.leftLabelText) ValueSlider(value: $viewModel.sliderPercentage, onEditingChanged: { editing in viewModel.sliderIsScrubbing = editing @@ -358,6 +360,8 @@ struct VLCPlayerOverlayView: View { Text(viewModel.rightLabelText) .font(.system(size: 18, weight: .semibold, design: .default)) .frame(minWidth: 70, maxWidth: 70) + .accessibilityLabel(L10n.remainingTime) + .accessibilityValue(viewModel.rightLabelText) } .padding(.horizontal) .frame(maxWidth: UIDevice.current.userInterfaceIdiom == .pad ? 800 : nil)