ashikk
/
jellyflood
1
0
Fork 0
Code Issues 8 Pull Requests Packages Projects Releases Wiki Activity

Fix login and settings screens on tvOS - use push navigation everywhere 

Changed all modal routes to push in login and settings coordinators:
- SelectUserCoordinator: login flow, server connection, advanced settings
- UserSignInCoordinator: quick connect, security settings
- SettingsCoordinator: all settings pages (both iOS and tvOS)
- AppSettingsCoordinator: log viewer

All screens now use full-screen push navigation instead of modal popups.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Ashik K 2025-10-17 12:27:52 +02:00
parent 8ad851ead1
commit d0a921d05c
4 changed files with 19 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Shared/Coordinators/AppSettingsCoordinator.swift
View File

@ -27,7 +27,7 @@ final class AppSettingsCoordinator: NavigationCoordinatable {
#endif #endif
#if os(tvOS) #if os(tvOS)
@Route(.modal) @Route(.push)
var log = makeLog var log = makeLog
@Route(.fullScreen) @Route(.fullScreen)

8
Shared/Coordinators/SelectUserCoordinator.swift
View File

@ -17,13 +17,13 @@ final class SelectUserCoordinator: NavigationCoordinatable {
@Root @Root
var start = makeStart var start = makeStart
@Route(.modal) @Route(.push)
var advancedSettings = makeAdvancedSettings var advancedSettings = makeAdvancedSettings
@Route(.modal) @Route(.push)
var connectToServer = makeConnectToServer var connectToServer = makeConnectToServer
@Route(.modal) @Route(.push)
var editServer = makeEditServer var editServer = makeEditServer
@Route(.modal) @Route(.push)
var userSignIn = makeUserSignIn var userSignIn = makeUserSignIn
func makeAdvancedSettings() -> NavigationViewCoordinator<AppSettingsCoordinator> { func makeAdvancedSettings() -> NavigationViewCoordinator<AppSettingsCoordinator> {

24
Shared/Coordinators/SettingsCoordinator.swift
View File

@ -26,11 +26,11 @@ final class SettingsCoordinator: NavigationCoordinatable {
var playbackQualitySettings = makePlaybackQualitySettings var playbackQualitySettings = makePlaybackQualitySettings
@Route(.push) @Route(.push)
var quickConnect = makeQuickConnectAuthorize var quickConnect = makeQuickConnectAuthorize
@Route(.modal) @Route(.push)
var resetUserPassword = makeResetUserPassword var resetUserPassword = makeResetUserPassword
@Route(.push) @Route(.push)
var localSecurity = makeLocalSecurity var localSecurity = makeLocalSecurity
@Route(.modal) @Route(.push)
var photoPicker = makePhotoPicker var photoPicker = makePhotoPicker
@Route(.push) @Route(.push)
var userProfile = makeUserProfileSettings var userProfile = makeUserProfileSettings
@ -51,12 +51,12 @@ final class SettingsCoordinator: NavigationCoordinatable {
var videoPlayerSettings = makeVideoPlayerSettings var videoPlayerSettings = makeVideoPlayerSettings
@Route(.push) @Route(.push)
var customDeviceProfileSettings = makeCustomDeviceProfileSettings var customDeviceProfileSettings = makeCustomDeviceProfileSettings
@Route(.modal) @Route(.push)
var itemOverviewView = makeItemOverviewView var itemOverviewView = makeItemOverviewView
@Route(.modal) @Route(.push)
var editCustomDeviceProfile = makeEditCustomDeviceProfile var editCustomDeviceProfile = makeEditCustomDeviceProfile
@Route(.modal) @Route(.push)
var createCustomDeviceProfile = makeCreateCustomDeviceProfile var createCustomDeviceProfile = makeCreateCustomDeviceProfile
@Route(.push) @Route(.push)
@ -69,19 +69,19 @@ final class SettingsCoordinator: NavigationCoordinatable {
#endif #endif
#if os(tvOS) #if os(tvOS)
@Route(.modal) @Route(.push)
var customizeViewsSettings = makeCustomizeViewsSettings var customizeViewsSettings = makeCustomizeViewsSettings
@Route(.modal) @Route(.push)
var experimentalSettings = makeExperimentalSettings var experimentalSettings = makeExperimentalSettings
@Route(.modal) @Route(.push)
var log = makeLog var log = makeLog
@Route(.modal) @Route(.push)
var serverDetail = makeServerDetail var serverDetail = makeServerDetail
@Route(.modal) @Route(.push)
var videoPlayerSettings = makeVideoPlayerSettings var videoPlayerSettings = makeVideoPlayerSettings
@Route(.modal) @Route(.push)
var playbackQualitySettings = makePlaybackQualitySettings var playbackQualitySettings = makePlaybackQualitySettings
@Route(.modal) @Route(.push)
var userProfile = makeUserProfileSettings var userProfile = makeUserProfileSettings
#endif #endif

4
Shared/Coordinators/UserSignInCoordinator.swift
View File

@ -23,11 +23,11 @@ final class UserSignInCoordinator: NavigationCoordinatable {
@Root @Root
var start = makeStart var start = makeStart
@Route(.modal) @Route(.push)
var quickConnect = makeQuickConnect var quickConnect = makeQuickConnect
#if os(iOS) #if os(iOS)
@Route(.modal) @Route(.push)
var security = makeSecurity var security = makeSecurity
#endif #endif