remove VLC screen filled

This commit is contained in:
Ethan Pippin 2021-12-30 13:54:24 -07:00
parent 604f41bffd
commit d5e225dce1
3 changed files with 0 additions and 35 deletions

View File

@ -103,18 +103,6 @@ struct VLCPlayerCompactOverlayView: View, VideoPlayerOverlay {
} }
} }
// Button {
// viewModel.screenFilled = !viewModel.screenFilled
// } label: {
// if viewModel.screenFilled {
// Image(systemName: "rectangle.arrowtriangle.2.inward")
// .rotationEffect(Angle(degrees: 90))
// } else {
// Image(systemName: "rectangle.arrowtriangle.2.outward")
// .rotationEffect(Angle(degrees: 90))
// }
// }
if !viewModel.subtitleStreams.isEmpty { if !viewModel.subtitleStreams.isEmpty {
Button { Button {
viewModel.playerOverlayDelegate?.didSelectCaptions() viewModel.playerOverlayDelegate?.didSelectCaptions()

View File

@ -134,24 +134,6 @@ class VLCPlayerViewController: UIViewController {
viewModel.sendPauseReport(paused: true) viewModel.sendPauseReport(paused: true)
} }
private func changeFill(to shouldFill: Bool) {
if shouldFill {
// TODO: May not be possible with current VLCKit
// let drawableView = vlcMediaPlayer.drawable as! UIView
// let drawableViewSize = drawableView.frame.size
// let mediaSize = vlcMediaPlayer.videoSize
// Largest size from mediaSize is how it is currently filled
// in the drawable view, find scaleFactor by filling entire
// drawableView
vlcMediaPlayer.scaleFactor = 1.5
} else {
vlcMediaPlayer.scaleFactor = 0
}
}
override func viewDidAppear(_ animated: Bool) { override func viewDidAppear(_ animated: Bool) {
super.viewDidAppear(animated) super.viewDidAppear(animated)
@ -309,10 +291,6 @@ extension VLCPlayerViewController {
self.vlcMediaPlayer.rate = Float(newSpeed.rawValue) self.vlcMediaPlayer.rate = Float(newSpeed.rawValue)
}.store(in: &viewModelReactCancellables) }.store(in: &viewModelReactCancellables)
viewModel.$screenFilled.sink { shouldFill in
self.changeFill(to: shouldFill)
}.store(in: &viewModelReactCancellables)
viewModel.$sliderIsScrubbing.sink { sliderIsScrubbing in viewModel.$sliderIsScrubbing.sink { sliderIsScrubbing in
if sliderIsScrubbing { if sliderIsScrubbing {
self.didBeginScrubbing() self.didBeginScrubbing()

View File

@ -34,7 +34,6 @@ final class VideoPlayerViewModel: ViewModel {
@Published var leftLabelText: String = "--:--" @Published var leftLabelText: String = "--:--"
@Published var rightLabelText: String = "--:--" @Published var rightLabelText: String = "--:--"
@Published var playbackSpeed: PlaybackSpeed = .one @Published var playbackSpeed: PlaybackSpeed = .one
@Published var screenFilled: Bool = false
@Published var sliderPercentage: Double { @Published var sliderPercentage: Double {
willSet { willSet {
sliderScrubbingSubject.send(self) sliderScrubbingSubject.send(self)