diff --git a/Shared/Generated/Strings.swift b/Shared/Generated/Strings.swift index 8b6fe26b..561ba3af 100644 --- a/Shared/Generated/Strings.swift +++ b/Shared/Generated/Strings.swift @@ -264,6 +264,10 @@ internal enum L10n { internal static var removeAllUsers: String { return L10n.tr("Localizable", "removeAllUsers") } /// Remove From Resume internal static var removeFromResume: String { return L10n.tr("Localizable", "removeFromResume") } + /// Report an Issue + internal static var reportIssue: String { return L10n.tr("Localizable", "reportIssue") } + /// Request a Feature + internal static var requestFeature: String { return L10n.tr("Localizable", "requestFeature") } /// Reset internal static var reset: String { return L10n.tr("Localizable", "reset") } /// Reset App Settings @@ -344,6 +348,8 @@ internal enum L10n { internal static var smallest: String { return L10n.tr("Localizable", "smallest") } /// Sort by internal static var sortBy: String { return L10n.tr("Localizable", "sortBy") } + /// Source Code + internal static var sourceCode: String { return L10n.tr("Localizable", "sourceCode") } /// STUDIO internal static var studio: String { return L10n.tr("Localizable", "studio") } /// Studios diff --git a/Swiftfin tvOS/Views/BasicAppSettingsView.swift b/Swiftfin tvOS/Views/BasicAppSettingsView.swift index 0e606e76..88b84e48 100644 --- a/Swiftfin tvOS/Views/BasicAppSettingsView.swift +++ b/Swiftfin tvOS/Views/BasicAppSettingsView.swift @@ -28,14 +28,14 @@ struct BasicAppSettingsView: View { Section { Button {} label: { HStack { - Text("Version") + L10n.version.text Spacer() Text("\(UIApplication.appVersion ?? "--") (\(UIApplication.bundleVersion ?? "--"))") .foregroundColor(.secondary) } } } header: { - Text("About") + L10n.about.text } // TODO: Implement once design is theme appearance friendly diff --git a/Swiftfin tvOS/Views/SettingsView/SettingsView.swift b/Swiftfin tvOS/Views/SettingsView/SettingsView.swift index ec11e449..6602038c 100644 --- a/Swiftfin tvOS/Views/SettingsView/SettingsView.swift +++ b/Swiftfin tvOS/Views/SettingsView/SettingsView.swift @@ -163,14 +163,14 @@ struct SettingsView: View { Section { Button {} label: { HStack { - Text("Version") + L10n.version.text Spacer() Text("\(UIApplication.appVersion ?? "--") (\(UIApplication.bundleVersion ?? "--"))") .foregroundColor(.secondary) } } } header: { - Text("About") + L10n.about.text } } } diff --git a/Swiftfin/Views/AboutView.swift b/Swiftfin/Views/AboutView.swift index f2fec306..62cd434f 100644 --- a/Swiftfin/Views/AboutView.swift +++ b/Swiftfin/Views/AboutView.swift @@ -21,6 +21,7 @@ struct AboutView: View { .cornerRadius(11) .frame(width: 150, height: 150) + // App name, not to be localized Text("Swiftfin") .fontWeight(.semibold) .font(.title2) @@ -34,7 +35,7 @@ struct AboutView: View { Section { HStack { - Text("Version") + L10n.about.text Spacer() Text("\(UIApplication.appVersion ?? "--") (\(UIApplication.bundleVersion ?? "--"))") .foregroundColor(.secondary) @@ -46,7 +47,7 @@ struct AboutView: View { .resizable() .frame(width: 20, height: 20) .foregroundColor(.primary) - Link("Source Code", + Link(L10n.sourceCode, destination: URL(string: "https://github.com/jellyfin/Swiftfin")!) .foregroundColor(.primary) @@ -58,7 +59,7 @@ struct AboutView: View { HStack { Image(systemName: "plus.circle.fill") - Link("Request a Feature", + Link(L10n.requestFeature, destination: URL(string: "https://github.com/jellyfin/Swiftfin/issues")!) .foregroundColor(.primary) @@ -70,7 +71,7 @@ struct AboutView: View { HStack { Image(systemName: "xmark.circle.fill") - Link("Report an Issue", + Link(L10n.reportIssue, destination: URL(string: "https://github.com/jellyfin/Swiftfin/issues")!) .foregroundColor(.primary) diff --git a/Swiftfin/Views/BasicAppSettingsView.swift b/Swiftfin/Views/BasicAppSettingsView.swift index 70f61d75..75bf5da1 100644 --- a/Swiftfin/Views/BasicAppSettingsView.swift +++ b/Swiftfin/Views/BasicAppSettingsView.swift @@ -35,7 +35,7 @@ struct BasicAppSettingsView: View { basicAppSettingsRouter.route(to: \.about) } label: { HStack { - Text("About") + L10n.about.text .foregroundColor(.primary) Spacer() Image(systemName: "chevron.right") diff --git a/Swiftfin/Views/SettingsView/SettingsView.swift b/Swiftfin/Views/SettingsView/SettingsView.swift index 81e2ebdc..79a134ce 100644 --- a/Swiftfin/Views/SettingsView/SettingsView.swift +++ b/Swiftfin/Views/SettingsView/SettingsView.swift @@ -173,7 +173,7 @@ struct SettingsView: View { settingsRouter.route(to: \.about) } label: { HStack { - Text("About") + L10n.about.text .foregroundColor(.primary) Spacer() Image(systemName: "chevron.right") diff --git a/Translations/en.lproj/Localizable.strings b/Translations/en.lproj/Localizable.strings index 48c1114e..454c8e7e 100644 Binary files a/Translations/en.lproj/Localizable.strings and b/Translations/en.lproj/Localizable.strings differ