* WIP
* Other Menu inits and AppSettingsView
* Linting & a touch of spacing.
* cleanup
* Init from CaseIterable
* User a Picker instead of just a ForEach
* Remove InlineEnumToggle.
* cleanup
---------
Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
* `VideoRangeType` "Extension" for now it's an enum until 10.10. Otherwise, done.
* Limit lines to 1 and variable width as needed.
* CodeFactor issue resolution
* AttributeViewModifier -> AttributeBadge
* change API
* `WrappingHStack`
---------
Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
* Ensure selectionViewModel is a valid season.
* Scolling issue
* Fix Scrolling! But fails to set button color...
* Move HStacks into their own folder.
* CollectionHStack
* SeasonHStack FINALLY done!
* ScrollToIndex NOT Element
* Remove refocus work
* Undo extra changes not for this PR
* Fix Episode Scrolling on iOS as well.
* Add the `.mask` in... Whatever that actually does??? Just trying to mirror the older version
* Linting
* Use playButtonItem instead
* Season ScrollTo
* Cleanup.
* Even more cleanup.
* Even more cleanup and comments
* LInting
* Catch empty episodes
* Linting.
* Mirror iOS more. Remove unused imports. Turn non-used cards into buttons to allow focus.
* Allow focusing on Empty / Error cards.
* Make ErrorCard Selectable
* cleanup
* Focusable Loading Card.
* Fall back to empty season.
* Last of the MacOS Catalyst stuff
* Force Unwrap.
* Don't force unwrap.
* Remove unneeded `focusedSection` from `EpisodeSelector`.
---------
Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
* Move Series Button to the About Section IF the item is an episode. Otherwise, continue using that image as just an image. tvOS & iOS.
* use posterbutton
---------
Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
* Button cleanup & errorViews
* Change the Sign Out button to be `ListRowButton`. Sets a better height value using `maxHeight` to ensure that it doesn't exceed the `ListRow` sizing.
* deleteUsersButton needs to be manually set back to 75
* wip
---------
Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
* Move ItemType to Filter
* Init but normally...
* filter on people?
* Default to easiest / least change solution.
* Reset `.collectionFolder`, `.folder`, and `.BaseItemPerson` in `PagingLibraryView` to have the default filters. This was originally in place. This Commit just ensures that iOS and tvOS have the same implementation.
* wip
* Update ItemLibraryViewModel.swift
* Update ItemLibraryViewModel.swift
---------
Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
* Update missing strings. Mirror iOS setting changes to make sure tvOS PagingLIbraryView updates with changes as well. Lay the groundwork for filtering.
* Revert back to rows over offset
* Reorder a bit.
* Move default layout to no values in closure. For whatever reason, I cannot do this to the non-defaults.
* 95% there
* Move `onChange`s to the `innerContent` to alleviate Type Checker issues
* All Value-less closures are moved with teh exception of viewModel.filterViewModel?.currentFilters
* Prepare for future letter picker location
* Add pin prompt to sign-in screen
* Bring over security views from iOS
* silence tvOS 17 warnings
* Add user profile and security views to routing
* Changes
* revert and remove commented code
* cleanup
* CodeFactor fixes
* Joe's Suggestions:
- Move UserProfileSettings to their own Coordinator
- Make Views Modal to better reflect existing items
- Fix CustomizeSettingsCoordinator (This is on me!)
- Change PINs to use SecureField
- Move all Settings View to use SplitFormWindowView to mirror existing Settings
- Use user profile image for SplitFormWindowView Icon
- Change Profile Security to use LearnMoreModal
- Use suggestion from https://forums.developer.apple.com/forums/thread/739545
- Tag Alert > TextFields with TODO so we can check this on tvOS 18
* Fix PIN for https://forums.developer.apple.com/forums/thread/739545 on SelectUserView
* Fix Build Issue.
* use user
---------
Co-authored-by: chickdan <=>
Co-authored-by: Joe <jpkribs@outlook.com>
Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
* Extract handlers into function
* Color Improvements to move away from UIColor
* Bring over edit user feature from iOS
* Fix UserGridButton overlay when editing
* Move advanced menu to be near server select menu
* Re-enable context menu
* Add bottom button bar
* hook up user deletion
* improvements
* Refactor buttons for highlight hover effect
* Pass in user count
* Don't cancel editing if delete alert is cancelled
* cleanup
* Pad bottom of buttons
* Cancel editing after user deletion
* Revert ServerSelectionMenu back to button
* Remove padding that pushed the server selection menu up too far
* Make delete button red to match iOS
* Update SelectUserView.swift
* workaround Menu layout issues
* Bring select/deselect all users behavior from iOS
* Fixes after merge with main
* Fix vertical focus
---------
Co-authored-by: chickdan <=>
Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
* Make user profile more generic. Still need to make it work for the reset image / other stuff like delete & username.
* Username Changing and PFP deletion.
* Functional, refreshing, and good to go!
* Clean up localizations
* Migrate [UserDto] -> IdentifiedArrayOf<UserDto>
* Solve "Username should probably be at the top of this section."
* allow notification filter
* WIP:
Created `UserProfileHeroImage` but I haven't used it anywhere.
* Centralize UserProfileHeroImages
* Rename UserProfileImages
* Fix Merge Issue?
* Move to UserProfileImage
* Merge with Main
* Fix Merge?
* Clear the cache on update.
* Delete duplicate `UserProfileImage`
* wip
* wip
* Update ImagePipeline.swift
* fix tvOS build issue and update comment to be more accurate
* clean up
* fix string
---------
Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
* Selection & Fix ServerSelectionMenu padding
* ButtonStyle
* Move from `FullScreenMenu` to just use `Menu` Remove usages of `FullScreenMenu` since it's no longer used anywhere else.
* Remove unused `FullScreenMenu`
* Remove unused `SelectServerView` since it's now in the `ServerSelectionMenu`
* Selection menu fixes
* Focus issues
* clean up
---------
Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
* UserSignInView and ConnectToServerView Cleanup
* Public User icon changes, move the Jellyfin 'NavigationBar' to a `View Modifier` for easier re-use.
* A better solution
* isLoading == isLoading NOT isLoading == true
* clean up
---------
Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
* Mirror tvOS to iOS
* Fix router dismiss. Remove redundent viewModel.refresh from itemView
* reset dev team info
* View Modifier and ViewModel cleanup
* Remove testing comments / events
* Cleanup `.errorMessage($error)`
* Cleanup all viewModel.states for item editing, add errorViews if the data fails to load, and add errorMessage on failed events.
MARK sections: Var/Func always unless only Body and Var/Lets only if there are several of varying types / functions.
* Partially resolve color todo
* Update localizations for quick connect steps. use bulleted list
* Same change for tvos
* Remove padding2 modifier
* Localisation
* Creation of an Alert Input Button based on the Chevron Button.
* Only one button required for both iOS and tvOS
* wip
---------
Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
* Update PosterButton.swift
Added accessibility labels to enable voice over on TVOS to read film titles on posters in media.
* lint
---------
Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
* Rebasing https://github.com/jellyfin/Swiftfin/pull/1212 on Main. Also, less baggage and random crap.
* Change 0 to Disabled. Better mirror iOS and tvOS Alerts for MaxNextUpDays.
* Review Changes:
Don't use the property wrappers in non-view contexts. While they technically can still work, use the subscript instead at the usage sites.
Use the dayInterval(0 ... 1000) format instead, then we don't need maxNextUpDays.
* Remove unused strings, and unused variables
* Add a tvOS TODO to double check the Done/Number button on the alert.
* Change password to be a SecureField and autosubmit on password completion
* Fix SelectUser Button
* Respond to comments and remove unnecessary changes
* Make FocusField a private enum
* Made the menu accessable and fixed visual padding bug
* Moved away from .onExitCommand etc
* Minor refactoring
* wip
* Update Overlay.swift
---------
Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
* Rename ExperimentalSettingsView.swift to PlaybackQualitySettingsView.swift
Fix Merge
* Rename MaximumBitrateSettingsView.swift to PlaybackQualitySettingsView.swift
fix merge
* Re-implement on Main. Should now have all the Main changed. Added a new change to use the Device Profile as a Transcoding Profile.
* Part 1 -> Making VideoPlayerType into a struct (I Hope) correctly
* Part 1.1 -> Making VideoPlayerType into a struct (I Hope) correctly
* Remove unneeded Files
* Missing file + CustomDeviceProfileSelection -> CustomDeviceProfileAction Rename
* Change + to Appending
* Attempt to add StorageValues+User. Not sure if this is correct?
* Move the Array unwrapping to funcitons. Not required but this should help prevent accidently doing this wrong. Add subtitles back into the custom profiles since that somehow got dropped. Added a PlaybackCompatibility enum. This might need to work for more than just video
* Complete rewrite to allow multiple profiles, compatibility mode, and directplay.
* Hardward -> Hardware
* Update CustomDeviceProfileSettingsView.swift
Double Licensing
* It was actually really easy to implement iOS... Trash cans still look weird and small.
* Swipe to Delete instead of the edit button
* wip
* wip
* Linting
* tvOS Implementation
* wip
* wip
* cleanup
* Create Package.resolved
---------
Co-authored-by: Joseph Kribs <joseph@kribs.net>
Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
* Focus on the first element if the lastFocusedEpisodeId isn't in the viewModel.
* Performance Improvements:
- Optimized Lookup: Used a Set for efficient checking of whether lastFocusedEpisodeID exists in viewModel.elements.
- Single Pass: Reduced the number of passes needed to check for existence and set the focusedEpisodeID.
* https://github.com/jellyfin/Swiftfin/pull/1185#pullrequestreview-2241625398 Suggestions
---------
Co-authored-by: Joseph Kribs <joseph@kribs.net>
* Settings Cleanup. Replace strings with labels. Enforce the same font. Ensure Forms don't get clipped by their boundries. Create consistent, reusable button sizing/coloring. Apply to all Settings Pages.
* Remove custom Button/Form styling in exchange for just using .scrollClipDisabled()
* Swap back to Jellyfin Purple from Purple.
* Remove Check Button. Check all Section Inits where possible. Make Server Details Server non-focusable.
Create a new menu for Server Details selection. This is a WIP awaiting feedback from https://github.com/jellyfin/Swiftfin/pull/1163#discussion_r1705957885
---------
Co-authored-by: Joseph Kribs <joseph@kribs.net>
* Creation of bitrate selections that mirror Jellyfin-Web. The goal is to eventually allow for these same selections to be available for usage in the Player itself to set the max bitrate per playback session. This App-Wide setting is for things like preserving data (Mobile) or for areas that have perpetually have low bandwidth (AppleTV). These settings currently default to 'Auto' which is the current limit of 360,000,000 bps / 360 mpbs. I have added a spot in BaseItemDTO+VideoPlayerViewModel to get the smaller amount between 360 Mpbs and the App Maximum Setting. This exists so I can go back and update this to get the Minumum between the Player Session max bitrate and the App Setting max bitrate.
Test on iPhone 10S, AppleTV 3rd Gen, and the iPhone 15 Pro via enumulator.
* Fix Bitrate naming (360p vs 480p) and remove the setting nested in a second section.
* Creation of a Maximum setting with 360mbps and an auto that gets the bitrate at playback.
* Remove comments for code where I want to eventually put it for better clarify
* Linting fixes
* Change the Playback Bitrate to an Int from a String since the Bitrate is valuable but the string isn't. Run the SwiftFormat on the maxBitrate function.
* Migrate the settings to their own menu with both the bitrate and the optional test size when auto is used.
* Creation of an enum filterValues function for Bitrate. This way, the selection on the Player Overlay (eventually) can be filtered to only include bitrates that are less than or equal to the App Setting for Maximum Bitrate. This should help prevent confusion / remove bandwidth conflicts.
The eventual Player Overlay setting should never conflict with the App-Wide Setting and should only offer options that are less than the App-Wide Setting.
* Change the videoPlayerViewModel to take parameters instead of defaults. Move the defaults up one level to be called there. Split the bitrate test from the getMaxBitrate to better guard against dividing against 0 and also split out the logic to be easier to read.
Change the PlaybackBitrate filter to always include Auto and, when auto, include ALL bitrates. This filter is not currently used.
* Remove the PlaybackBitrate FilterValues since this is not needed and will be created ad-hoc.
* Update the bitrateTestDuration verbage to better reflect that you're changing the size of the bitrate test and not just increasing the duration. Re-use the existing largest to smallest labels since there isn't a ton of benefit using "Longest to Shortest" so this should re-use existing localization. Comment the Labels.
No functional changes. Only an update to labels.
* Delete the Bitrate.json file but retain the Resources folder.
* Remove Resource Folder.
---------
Co-authored-by: Joe Kribs <joseph@kribs.net>
Joe Kribs
Daniel Chick
samglt
Ethan Pippin
Peter Hamilton
Peter McNeil
Mats Eikeland Mollestad
Steve Byatt
Dhocking