Development for jellyflood
Go to file
Joe Kribs 553441d83e
[iOS] Media Item Menu - Edit Item Images (#1345)
* Good start but some missing items:

- Upload image isn't working
- Only a single image is shown per section. Need to make this the HCollection of all images for the group

* Upload still failing but now update and set are 2 different processes because I think that's better. Spacing on the add screen is still all wrong but we're getting closer

* ~70% Complete

TODO:

- Spacing for remote portrait images is wrong & cramped
- Upload image from file browser never works & produces 400 error
- Show all images for an item.imageType opposed to just the first
- Setting image works but produces a 400 error
- Error alert looks bad

* Merge with Main

* URL Changes

* Updating logic and confirmation screen

* Lots of changes:

Selecting a Remote image is now working without error and works consistently!

Upload a local file is still broken

Item types with multiple images is working as intended now!

Overriding an image on index doesn't seem to work but it doesn't work for Web either so........

UI is way more jank but the hard parts are getting solved!

* Breaking this even more with the hopes of a better tomorrow.

* Getting better?

* Refreshing is working but I might need to make this work mroe effiently...

* 90% There!

* Ability to cancel the update

* Still no luck uploading images?

* Stop reordering on deletion/addition

* 2025 disclaimers

* Uploading finally works!

* Functional but messy.

TODO:
- Figure out better resizing if too big?
- Upload from Photos
- Move upload logic to imageViewModel and make RemtoeImageViewModel PagingLibraryViewModel conformant
- Create a ImageInfoView for Selection & Deletion.

* Now conforms to PagingLIbraryViewModel but everything else is a mess

* Close!

* First no all appears

* Fix double pop/routerdismiss

* Uploading from Photos is (Finally) Ready!

* wip

* Reuse PhotoPicker and Crop code.

* 4/6 of the codefactor changes

* Pass around the URL NOT the UIImage

* Clean up ItemImageDetails types.

* Make sure the ImageView mirrors the real shape of the image. Posters should be uniform but this is the selection for the image so the dimensions are important to demonstrate.

* Rating Type label.

* Delete confirmation dialog.

* Remove double sizing. Remove Unused ViewModel. Change PhotoPicker to a checkmark instead a 1. Since there is only ever one picture selected, no need to count the images.

* Get the image URL as needed. No more Truples.  Localize ImageTypes.

* Remove attempt at ImageInfo Poster Comformance.

* Even more cleanup

* Delete vs Save flip

* Hide delete button

* Even more cleanup

* Fix tvOS build issues.

* Reduce delay & remove unused comment. Should finally be ready again.

* wip

* Update ItemImagesView.swift

* Event Only on upload failures.

* Remove unnecessary ViewModel's from tvOS.

* Add dismiss action to RemoteSearchResultView. While I am doing this here, fix it there.

* Move From Coordinator -> .Sheet. This fixes the popping issue / delay requirement!

* wip

* wip

* wip

* wip

---------

Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
2025-01-20 16:17:35 -05:00
.github Update and Clean Up CI (#1314) 2024-11-14 15:56:58 -07:00
Documentation [Meta] Player Comparison Page (#1302) 2024-11-04 16:21:18 -07:00
PreferencesView [Meta] 2025 Disclaimer (#1381) 2025-01-02 16:05:15 -07:00
Resources update (#1356) 2024-12-10 19:15:43 -07:00
Scripts/Translations [Meta] 2025 Disclaimer (#1381) 2025-01-02 16:05:15 -07:00
Shared [iOS] Media Item Menu - Edit Item Images (#1345) 2025-01-20 16:17:35 -05:00
Swiftfin [iOS] Media Item Menu - Edit Item Images (#1345) 2025-01-20 16:17:35 -05:00
Swiftfin tvOS [iOS & tvOS] Series Extras (#1398) 2025-01-16 19:52:12 -05:00
Swiftfin.xcodeproj [iOS] Media Item Menu - Edit Item Images (#1345) 2025-01-20 16:17:35 -05:00
Translations [iOS] Media Item Menu - Edit Item Images (#1345) 2025-01-20 16:17:35 -05:00
fastlane Trim Fastlane Options (#1367) 2024-12-17 14:58:44 -07:00
.gitignore [tvOS] Change password to be a SecureField and autosubmit on password comple… (#1090) 2024-10-06 02:24:28 -06:00
.swiftformat Project Settings Changes (#1297) 2024-10-31 13:18:19 -06:00
Cartfile VLCKit Hard Versioning (#1136) 2024-06-30 16:05:26 +09:00
ChromeCastFramework.json #983 Fixing build instructions (#985) 2024-03-10 19:46:59 -06:00
Gemfile Initial fastlane Setup (#1089) 2024-06-09 22:08:43 -06:00
LICENSE.md Fix some formatting 2021-06-09 23:15:51 -07:00
README.md update (#1356) 2024-12-10 19:15:43 -07:00
RedrawOnNotificationView.swift [Meta] 2025 Disclaimer (#1381) 2025-01-02 16:05:15 -07:00
swiftgen.yml Navigation and Item Overhaul (#492) 2022-08-05 10:54:40 -06:00

README.md

Swiftfin

Swiftfin

Swiftfin is a modern video client for the Jellyfin media server. Made using Swift to maximize direct play with the power of VLC and look native on all classes of Apple devices.

Download

Download on the Apple App Store

🛠️ TestFlight

Use the TestFlight version to test new features and bug fixes before being published to the App Store. We are grateful for your time and resources for reporting new bugs.

[!NOTE] Only iOS has a TestFlight version. See this discussion for tvOS updates.

Get the beta on TestFlight

⚙️ Development

Thank you for your interest in Swiftfin! Please check out the Contribution Guidelines to get started.

🎬 Player Differences

Swiftfin offers both Native (AVKit) and Swiftfin (VLCKit) players to provide the best compatibility across Apple devices. To learn more about the capabilities and differences between these players, visit our Player Differences documentation.

📚 Translations

Don't see Swiftfin in your language?

Check out our Weblate instance to help translate Swiftfin and other Jellyfin projects.