ashikk
/
jellyflood
1
0
Fork 0
Code Issues 8 Pull Requests Packages Projects Releases Wiki Activity

Fix video player back button - use push navigation 

Changed video player from .fullScreen to .push navigation:
- Removed NavigationViewCoordinator wrapper
- Video player now returns VideoPlayerCoordinator directly

This should allow ESC/back button to work during video playback.

MediaCoordinator kept at .fullScreen to prevent Home screen navigation bug.

Trade-offs:
✅ Video player ESC should now work
✅ Pressing back from empty channel goes to Media tab (not Home)
❌ Error dismissal still returns to Media tab (dismisses entire .fullScreen presentation)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Ashik K 2025-10-17 12:49:26 +02:00
parent 7c28c04048
commit 0dcde5dd74
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Shared/Coordinators/ItemCoordinator.swift
View File

@ -40,7 +40,7 @@ final class ItemCoordinator: NavigationCoordinatable {
var itemOverview = makeItemOverview var itemOverview = makeItemOverview
@Route(.fullScreen) @Route(.fullScreen)
var mediaSourceInfo = makeMediaSourceInfo var mediaSourceInfo = makeMediaSourceInfo
@Route(.fullScreen) @Route(.push)
var videoPlayer = makeVideoPlayer var videoPlayer = makeVideoPlayer
#endif #endif
@ -90,8 +90,8 @@ final class ItemCoordinator: NavigationCoordinatable {
#endif #endif
#if os(tvOS) #if os(tvOS)
func makeVideoPlayer(manager: VideoPlayerManager) -> NavigationViewCoordinator<VideoPlayerCoordinator> { func makeVideoPlayer(manager: VideoPlayerManager) -> VideoPlayerCoordinator {
NavigationViewCoordinator(VideoPlayerCoordinator(manager: manager)) VideoPlayerCoordinator(manager: manager)
} }
#endif #endif